Skip to content

Refactor/376 : 빌드시 MCP 스프링부트테스트로 타임아웃 발생 방지#383

Merged
HeeMang-Lee merged 4 commits intodevfrom
refactor/376
Aug 12, 2025
Merged

Refactor/376 : 빌드시 MCP 스프링부트테스트로 타임아웃 발생 방지#383
HeeMang-Lee merged 4 commits intodevfrom
refactor/376

Conversation

@HeeMang-Lee
Copy link
Copy Markdown
Member

@HeeMang-Lee HeeMang-Lee commented Aug 12, 2025 •
edited by coderabbitai bot
Loading

🔎 작업 내용

  • 빌드시 MCP 스프링부트테스트로 타임아웃 발생 방지

Summary by CodeRabbit

  • 신기능: 없음
  • 버그 수정
    • 외부 검색 연동의 요청 제한 시간을 60초로 늘려 간헐적 타임아웃을 완화하고 연결 안정성을 개선했습니다.
    • 검색 커넥터 실행 경로 설정을 정비해 초기화 및 연결 성공률을 향상했습니다.
  • 작업(Chores)
    • 빌드 과정 최적화 및 테스트 생략으로 배포 시간을 단축하고 빌드 안정성을 높였습니다.
  • 스타일
    • 코드 포맷을 정리해 일관성을 향상했습니다.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 12, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Dockerfile에 테스트 스킵 및 MCP 비활성화용 ENV가 추가되고 Gradle wrapper 실행 권한이 설정되었습니다. BraveSearchMcpService.java는 포맷팅만 변경되었습니다. application.properties에서 MCP 타임아웃이 60초로 증가, Brave 커맨드 경로가 절대경로로 변경되었고 두 개의 MCP/자동구성 관련 프로퍼티가 제거되었습니다.

Changes

Cohort / File(s) Summary
Docker 빌드 구성
cs25-service/Dockerfile		 Gradle 빌드 시 테스트 스킵(-x test), MCP 비활성화 ENV 추가(SPRING_AI_MCP_CLIENT_ENABLED/INITIALIZED=false), chmod +x ./gradlew 추가.
Brave MCP 서비스(포맷)
cs25-service/src/main/java/com/example/cs25service/domain/ai/service/BraveSearchMcpService.java		 불필요 공백 제거 등 포맷팅 변경만 존재. 동작 변화 없음.
애플리케이션 설정(MCP/Brave)
cs25-service/src/main/resources/application.properties		 spring.ai.mcp.client.request-timeout: 45s→60s, ...stdio.connections.brave.command: server-brave-search→/usr/local/bin/server-brave-search, spring.ai.mcp.client.initialized 및 spring.autoconfigure.exclude 제거.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • Kimyoonbeom
  • wannabeing
  • crocusia

Poem

칙칙폭폭, 컨테이너 길 떠나네—
테스트는 패스! 난 깡총 토끼 🐇
Brave는 절대경로로 또각또각,
타임아웃 늘려 숨 좀 고르고—
ENV로 MCP 꿈잠 재우니,
빌드숲 사이 바람이 맑다.
(o^_^o)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c362098 and ca8317e.

📒 Files selected for processing (3)
  • cs25-service/Dockerfile (1 hunks)
  • cs25-service/src/main/java/com/example/cs25service/domain/ai/service/BraveSearchMcpService.java (2 hunks)
  • cs25-service/src/main/resources/application.properties (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/376

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@HeeMang-Lee HeeMang-Lee merged commit b5dece4 into dev Aug 12, 2025
1 check was pending
@HeeMang-Lee HeeMang-Lee deleted the refactor/376 branch August 12, 2025 06:35
@HeeMang-Lee HeeMang-Lee restored the refactor/376 branch August 12, 2025 06:40
@wannabeing wannabeing linked an issue Aug 12, 2025 that may be closed by this pull request
[08.11]10차 배포 후 백엔드 모든 요청에 502에러 반환 #366
Closed
@wannabeing wannabeing deleted the refactor/376 branch August 12, 2025 08:45
@coderabbitai coderabbitai bot mentioned this pull request Aug 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[08.11]10차 배포 후 백엔드 모든 요청에 502에러 반환

1 participant

@HeeMang-Lee